feat: Support for description completionItem #724
Conversation
|
@Enaium could you please do 2 screenshots (with and without your PR) to show the result of completion item please. |
|
Before: Now: |
| @@ -165,7 +165,8 @@ public String getItemText(@NotNull CompletionItem item) { | |||
| */ | |||
| @Nullable | |||
| public String getTypeText(CompletionItem item) { | |||
| return item.getDetail(); | |||
| var labelDetails = item.getLabelDetails(); | |||
| return labelDetails != null ? labelDetails.getDescription() : null; | |||
There was a problem hiding this comment.
how about labelDetails == null ? item.getDetail() : labelDetails.getDescription(); ?
There was a problem hiding this comment.
The description is worked in vscode
| @@ -165,7 +165,8 @@ public String getItemText(@NotNull CompletionItem item) { | |||
| */ | |||
| @Nullable | |||
| public String getTypeText(CompletionItem item) { | |||
| return item.getDetail(); | |||
| var labelDetails = item.getLabelDetails(); | |||
| return labelDetails != null ? labelDetails.getDescription() : null; | |||
There was a problem hiding this comment.
@Enaium I have tested your PR with other language server like TypeScript, Go etc which doesn't support label detail and the renderer is bad:
The detail in this case must be displayed on the right (like vscode does). Please change with
return labelDetails != null ? labelDetails.getDescription() : item.getDetail();
| @@ -199,7 +200,7 @@ public boolean isStrikeout(@NotNull CompletionItem item) { | |||
| @Nullable | |||
| public String getTailText(@NotNull CompletionItem item) { | |||
| var labelDetails = item.getLabelDetails(); | |||
| return labelDetails != null ? labelDetails.getDetail() : null; | |||
| return labelDetails != null ? labelDetails.getDetail() : item.getDetail(); | |||
There was a problem hiding this comment.
Please keep the original code like:
return labelDetails != null ? labelDetails.getDetail() : null;
There was a problem hiding this comment.
Sorry it is not resolved, please keep the original code:
return labelDetails != null ? labelDetails.getDetail() : null;
|
@Enaium once you will do the fix for #724 (comment) I'm OK to merge your PR. |
Enaium
force-pushed
the
main
branch
3 times, most recently
from
3b12c2f to
29fa77f
Compare
|
Thanks @Enaium ! |
|
it's working fine now. |
|
@Enaium you can install nightly-builds and enjoy with your fix. |
|
Ok |
No description provided.